Skip to content

[Common] Compile headers#16993

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:clang-headers-Common
Jul 13, 2026
Merged

[Common] Compile headers#16993
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:clang-headers-Common

Conversation

@vkucera

@vkucera vkucera commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Provides missing compile commands needed by Clang-Tidy.

@vkucera
Compile headers
86bfeb0 
Provides missing compile commands needed by Clang-Tidy.
@github-actions github-actions Bot added the common label Jul 9, 2026
@github-actions github-actions Bot changed the title Compile headers [Common] Compile headers Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 23 errors, ⚠️ 34 warnings, 🔕 0 disabled

@vkucera vkucera marked this pull request as ready for review July 9, 2026 15:35
@alibuild

alibuild commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 86bfeb0 at 2026-07-11 01:38:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 27 errors and 15 warnings.'
Found 27 errors and 15 warnings.
++ [[ 27 -gt 0 ]]
++ cat /sw/BUILD/d482353f48e715172d61cb3d8e62e213abd42619/O2Physics-code-check/errors.txt
Common/Tools/PID/pidTPCModule.h:58:10: error: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:60:1: error: nested namespaces can be concatenated [modernize-concat-nested-namespaces,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:99:82: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:100:76: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:105:94: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:177:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:186:28: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:223:15: error: redundant string initialization [readability-redundant-string-init,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:269:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:273:17: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:286:15: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:311:45: error: the const qualified parameter 'particle' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:349:9: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:407:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:416:191: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:416:241: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:425:15: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:455:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:491:189: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:491:239: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:521:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:529:9: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:777:13: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:785:11: error: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:815:16: error: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:816:13: error: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables,-warnings-as-errors]
Common/Tools/PID/pidTPCModule.h:880:13: error: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty,-warnings-as-errors]
++ [[ 15 -gt 0 ]]
++ cat /sw/BUILD/d482353f48e715172d61cb3d8e62e213abd42619/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:632:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:634:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:640:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:642:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:650:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:652:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:684:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:686:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:836:39: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:838:31: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:847:38: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:849:43: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:861:39: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 86bfeb0 at 2026-07-12 15:38:

No log files found

Full log here.

@vkucera vkucera merged commit 059b496 into AliceO2Group:master Jul 13, 2026
10 of 14 checks passed
@vkucera vkucera deleted the clang-headers-Common branch July 13, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkucera @alibuild